Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deprecation)!: remove deprecated getCollections() #624

Merged
merged 2 commits into from
May 15, 2019
Merged

refactor(deprecation)!: remove deprecated getCollections() #624

merged 2 commits into from
May 15, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 15, 2019 •
edited by JustinBeckwith
Loading

BREAKING CHANGE: This removes the deprecated getCollections() method (deprecated in Oct 2018). This will be part of the v2 release.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
mikelehen
mikelehen approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JustinBeckwith JustinBeckwith changed the title breaking: Remove deprecated getCollections() breaking!: Remove deprecated getCollections() May 15, 2019
@JustinBeckwith
Copy link
Contributor

Just FYI - updated the PR title and desc to more closely match what I think? conventional commits wants. @bcoe should peek too.

@schmidt-sebastian schmidt-sebastian assigned bcoe and unassigned mikelehen May 15, 2019
@bcoe bcoe changed the title breaking!: Remove deprecated getCollections() refactor(deprecation)!: remove deprecated getCollections() May 15, 2019
@bcoe
Copy link
Contributor

bcoe commented May 15, 2019

editing commit title party, woo 😛 I'd probably do something like what I just changed it to ... it's a refactor, removing something deprecated, which breaks things.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #624 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   61.45%   61.52%   +0.06%     
==========================================
  Files          21       21              
  Lines        3409     3407       -2     
  Branches      460      460              
==========================================
+ Hits         2095     2096       +1     
+ Misses       1252     1250       -2     
+ Partials       62       61       -1
Impacted Files Coverage Δ
dev/src/index.ts 95.01% <ø> (-0.02%) ⬇️
dev/src/reference.ts 99.01% <ø> (-0.01%) ⬇️
dev/src/watch.ts 97.68% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22f9c6...3389d30. Read the comment docs.

@codecov
Copy link

codecov bot commented May 15, 2019 •
edited
Loading

Codecov Report

Merging #624 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   61.54%   61.52%   -0.03%     
==========================================
  Files          21       21              
  Lines        3409     3407       -2     
  Branches      460      460              
==========================================
- Hits         2098     2096       -2     
  Misses       1250     1250              
  Partials       61       61
Impacted Files Coverage Δ
dev/src/index.ts 95.01% <ø> (-0.02%) ⬇️
dev/src/reference.ts 99.01% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22f9c6...3389d30. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 43ac9c6 into master May 15, 2019
@yoshi-automation yoshi-automation mentioned this pull request May 17, 2019
Closed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-removelistcollections branch May 17, 2019 22:56
This was referenced May 17, 2019
Closed
Closed
Closed
Closed
Closed
Merged
yoshi-automation added a commit that referenced this pull request Oct 22, 2020
@yoshi-automation
Merge pull request #624 from vchudnov-g/drift-metadata
6f3e8fe 
Add schema for providing GAPIC metadata

Source-Author: Victor Chudnovsky <[email protected]>
Source-Date: Mon Oct 19 14:48:15 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 34c5a5c5132a2c5ef46f599550a1195e07f01f80
Source-Link: googleapis/googleapis@34c5a5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@bcoe bcoe

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schmidt-sebastian @JustinBeckwith @bcoe @mikelehen @googlebot